Re: Allow CURRENT_ROLE in GRANTED BY
Simon Riggs <simon@2ndquadrant.com>
From: Simon Riggs <simon@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Vik Fearing <vik@postgresfriends.org>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-12-30T12:43:39Z
Lists: pgsql-hackers
On Thu, 10 Dec 2020 at 18:40, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > > On 2020-06-24 20:21, Peter Eisentraut wrote: > > On 2020-06-24 10:12, Vik Fearing wrote: > >> On 6/24/20 8:35 AM, Peter Eisentraut wrote: > >>> I was checking some loose ends in SQL conformance, when I noticed: We > >>> support GRANT role ... GRANTED BY CURRENT_USER, but we don't support > >>> CURRENT_ROLE in that place, even though in PostgreSQL they are > >>> equivalent. Here is a trivial patch to add that. > >> > >> > >> The only thing that isn't dead-obvious about this patch is the commit > >> message says "[PATCH 1/2]". What is in the other part? > > > > Hehe. The second patch is some in-progress work to add the GRANTED BY > > clause to the regular GRANT command. More on that perhaps at a later date. > > Here is the highly anticipated and quite underwhelming second part of > this patch set. Looks great, but no test to confirm it works. I would suggest adding a test and committing directly since I don't see any cause for further discussion. -- Simon Riggs http://www.EnterpriseDB.com/
Commits
-
Fix GRANTED BY support in REVOKE ROLE statements
- b2a459edfe64 15.0 landed
- 371087d006e0 14.2 landed
-
Allow GRANTED BY clause in normal GRANT and REVOKE statements
- 6aaaa76bb47d 14.0 landed
-
Try to stabilize output from rolenames regression test.
- e5209bf37a27 14.0 landed
-
Allow CURRENT_ROLE where CURRENT_USER is accepted
- 45b9805706fd 14.0 landed