Horton

Re: [PATCH] Add pretty-printed XML output option

Nikolay Samokhvalov <samokhvalov@gmail.com>

View thread View on postgr.es
From: Nikolay Samokhvalov <samokhvalov@gmail.com>
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Smith <smithpb2250@gmail.com>, Andrey Borodin <amborodin86@gmail.com>
Date: 2023-02-22T07:05:38Z
Lists: pgsql-hackers 
On Mon, Feb 20, 2023 at 3:06 PM Jim Jones <jim.jones@uni-muenster.de> wrote:

> As suggested by Peter and Nikolay, v15 now removes the xmlformat
> function from the catalog and adds the [NO] INDENT option to
> xmlserialize, as described in X069.\
>

Great. I'm checking this patch and it seems, indentation stops working if
we have a text node inside:

gitpod=# select xmlserialize(document '<xml><more>13</more></xml>' as text
indent);
              xmlserialize
----------------------------------------
 <?xml version="1.0" encoding="UTF-8"?>+
 <xml>                                 +
   <more>13</more>                     +
 </xml>                                +

(1 row)

gitpod=# select xmlserialize(document '<xml>text<more>13</more></xml>' as
text indent);
              xmlserialize
----------------------------------------
 <?xml version="1.0" encoding="UTF-8"?>+
 <xml>text<more>13</more></xml>        +

(1 row)

Worth to mention, Oracle behaves similarly -- indentation doesn't work:
https://dbfiddle.uk/hRz5sXdM.

But is this as expected? Shouldn't it be like this:
<xml>
  text
  <more>13</more>
</xml>
?

Commits

  1. Fix memory leak in XMLSERIALIZE(... INDENT).

  2. doc: Move documentation of md5_password_warnings to a better place

  3. Support [NO] INDENT option in XMLSERIALIZE().

  4. Add an expected-file to match behavior of latest libxml2.