Horton
Menu

Re: [PATCH] PGSERVICEFILE as part of a normal connection string

Ryo Kanbayashi <kanbayashi.dev@gmail.com>

View thread
From: Ryo Kanbayashi <kanbayashi.dev@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Torsten Förtsch <tfoertsch123@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-07-14T09:41:56Z
Lists: pgsql-hackers 
On Mon, Jul 14, 2025 at 9:10 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Jul 10, 2025 at 02:21:38PM +0900, Michael Paquier wrote:
> > After that, I have applied a few cosmetic tweaks here and there, and
> > attached is what I have staged for commit, minus proper commit
> > messages.  The new TAP tests have some WIN32-specific things, and I
> > won't be able to look at the buildfarm if I were to apply things
> > today, so this will have to wait until the beginning of next week.
> > The CI is happy with it, so at least we are one checkbox down.
>
> Both are now applied as of 6b1c4d326b06 and 092f3c63efc6.
>
> The scary part was the WIN32 buildfarm members, which I've confirmed
> have accepted the new tests.  So we should be good here.

Thank you for your long-time review responses and comments :)

I will do my best for next patch as well :)

---
Great regards,
NTT Open Source Software Center
Ryo Kanbayashi

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. psql: Add variable SERVICEFILE

  2. libpq: Add "servicefile" connection option

  3. libpq: Add TAP test for nested service file

  4. libpq: Fix some issues in TAP tests for service files

  5. docs: Fix column count attribute in table

  6. libpq: Add TAP tests for service files and names