Horton

Re: Fix incorrect function reference BufFileOpenShared in comment.

Zhang Mingli <zmlpostgres@gmail.com>

View thread
From: Mingli Zhang <zmlpostgres@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-03T09:16:50Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix incorrect function reference in comment

  2. Refactor sharedfileset.c to separate out fileset implementation.

Thanks.

Richard Guo <guofenglinux@gmail.com>于2025年10月3日 周五15:41写道：

> On Wed, Oct 1, 2025 at 6:29 PM Richard Guo <guofenglinux@gmail.com> wrote:
> > On Wed, Oct 1, 2025 at 5:15 PM Zhang Mingli <zmlpostgres@gmail.com>
> wrote:
> > > The comment incorrectly cited the defunct function BufFileOpenShared()
> > > which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.
> > >
> > > Update the reference to the current function: BufFileOpenFileSet().
>
> > Nice catch.  Running `git grep 'BufFile.*Shared'` confirms that this
> > is the only place referencing the outdated BufFileXXXShared()
> > functions.  I'll push this patch barring any objections.
>
> Pushed.
>
> - Richard
>