Horton

Re: pl/perl extension fails on Windows

Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>

View thread View on postgr.es
From: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Christoph Berg <myon@debian.org>, Tom Lane <tgl@sss.pgh.pa.us>, Ashutosh Sharma <ashu.coek88@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-08-08T16:15:35Z
Lists: pgsql-hackers

Attachments

On Tue, Aug 8, 2017 at 8:19 PM, Robert Haas <robertmhaas@gmail.com> wrote:

> On Tue, Aug 8, 2017 at 8:37 AM, Sandeep Thakkar
> <sandeep.thakkar@enterprisedb.com> wrote:
> > An update from beta3 build: We are no longer seeing this issue (handshake
> > failure) on Windows 64bit, but on Windows 32bit it still persists.
>
> Hmm, maybe you should've reported it sooner, so we could've tried to
> fix this before beta3 went out.
>
> Yes, that would have been better. The patch was tested only on Windows
64bit and we never thought that it won't work on 32bit.


> What was the exact message you saw, including the hex values?
>
> Attach is the screenshot of the contents of the postmaster log that was
sent to me by one of my team members who was testing this.


> Is the Perl you were building against for plperl the same Perl that
> was being used for the build itself?
>
> Yes.


> Do you have the portion of the build log where src/pl/plperl was being
> built?
>
> I copied and pasted that portion of the build log into file build.log
(attached) for Windows 32bit and Windows 64bit.

Thanks.

> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Sandeep Thakkar
EDB

Commits

  1. MSVC: Test whether 32-bit Perl needs -D_USE_32BIT_TIME_T.

  2. Further tweaks to compiler flags for PL/Perl on Windows.

  3. Absorb -D_USE_32BIT_TIME_T switch from Perl, if relevant.

  4. PL/Perl portability fix: absorb relevant -D switches from Perl.

  5. PL/Perl portability fix: avoid including XSUB.h in plperl.c.