Horton

Re: [EXTERNAL] Re: Windows Application Issues | PostgreSQL | REF # 48475607

Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>

View thread
From: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: "Haifang Wang (Centific Technologies Inc)" <v-haiwang@microsoft.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>, Rahul Pandey <pandeyrah@microsoft.com>, Vishwa Deepak <Vishwa.Deepak@microsoft.com>, Shawn Steele <Shawn.Steele@microsoft.com>, Amy Wishnousky <amyw@microsoft.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>, Shweta Gulati <gulatishweta@microsoft.com>, Ashish Nawal <nawalashish@microsoft.com>
Date: 2024-09-05T11:46:40Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Reject non-ASCII locale names.

On Thu, Sep 5, 2024 at 5:46 AM Thomas Munro <thomas.munro@gmail.com> wrote:

> On Thu, Sep 5, 2024 at 12:07 PM Haifang Wang (Centific Technologies
> Inc) <v-haiwang@microsoft.com> wrote:
> > Good to know that, Thomas. I'm asking our tester to try it. Will let you
> know.
>
> To give a more serious response, I don't really expect anything
> "simple" about this patch not to work on Windows, as I know that it it
> rejects non-ASCII names as I showed (on all OSes), and I know that
> compiles and passes our tests on all our 4 CI operating systems:
>
> https://cirrus-ci.com/build/4941642090676224
>
> Really what I'm looking for is (1) feedback on the approach, code and
> comments, and thoughts about more complex scenarios I may have failed
> to think about, including say, pg_dump, pg_upgrade etc operational
> issues, which probably involves lots of previous experience with
> PostgreSQL, (2) opinions on whether we should add a test for these
> cases and how to put the UTF-8 into a script (I'm confused about the
> encoding of command line arguments), and (3) a nod from the EDB people
> involved in distributing this software on Windows.
>

We can help with producing the builds with the patches provided. You had
also
mentioned about the changes required in the installer script, will it still
be required?


-- 
Sandeep Thakkar