master fails to build on Windows
Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
From: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
To: pgsql-hackers@postgresql.org
Date: 2018-05-18T09:29:38Z
Lists: pgsql-hackers
Attachments
- v11-win64-errors.log (application/octet-stream)
Hi
I was building the sources I got from https://www.postgresql.org/
ftp/snapshot/dev/ on Windows x64 and got the whole bunch of errors
like "*Cannot
open include file: 'catalog/pg_type_d.h"* , *"Cannot open include file:
'catalog/pg_tablespace_d.h'" . *I've attached the log.
The renaming was done as part of following commit, but the location where
*_d.h are present is not included in INCLUDE. Example: pg_type.h is present
at *src/include/catalog/ *and pg_type_d.h is present at
*src/backend/catalog/*. I added the required path in MSBuildProject.pm and
the build is passed. Here is the diff:
298c298
< <AdditionalIncludeDirectories>$self->{prefixincludes}src/
include;src/include/port/win32;src/include/port/win32_msvc;$includes\%(
AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
---
> <AdditionalIncludeDirectories>$self->{prefixincludes}src/
include;src/backend;src/include/port/win32;src/include/port/win32_msvc;$
includes\%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
commit 9c0a0de4c91b2dc911220d769cf2c5f754cfcb90
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun Apr 8 13:59:52 2018 -0400
--
Sandeep Thakkar
Commits
-
MSVC builds must use a separate stamp file for copying generated headers.
- a194106c1b44 11.0 landed
-
Switch client-side code to include catalog/pg_foo_d.h not pg_foo.h.
- 9c0a0de4c91b 11.0 cited