Horton

Re: Make pg_stat_io view count IOs as bytes instead of blocks

Nazir Bilal Yavuz <byavuz81@gmail.com>

View thread View on postgr.es
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Melanie Plageman <melanieplageman@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-14T13:43:28Z
Lists: pgsql-hackers 
Hi,

On Tue, 14 Jan 2025 at 06:18, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Jan 10, 2025 at 08:23:46AM +0000, Bertrand Drouvot wrote:
> > On Fri, Jan 10, 2025 at 10:15:52AM +0300, Nazir Bilal Yavuz wrote:
> >> But I agree that having a macro has more benefits,
> >> also there already is a check for the 'io_op < IOOP_NUM_TYPES' in the
> >> pgstat_count_io_op() function.
> >
> > Yeah, I think we can remove the "io_op < IOOP_NUM_TYPE" assertion in
> > pgstat_count_io_op() (but keep this check as part of the macro).
> >
> > Appart from the above, LGTM.
>
> Okay, so applied.
>
> And I've somewhat managed to fat-finger the business with
> pgstat_count_io_op() with an incorrect rebase.  Will remove in a
> minute..

Thank you!

-- 
Regards,
Nazir Bilal Yavuz
Microsoft

Commits

  1. Rework macro pgstat_is_ioop_tracked_in_bytes()

  2. Remove assertion in pgstat_count_io_op()

  3. Make pg_stat_io count IOs as bytes instead of blocks for some operations

  4. Merge pgstat_count_io_op_n() and pgstat_count_io_op()