Thread

Re: Remove unused function parameters, part 1: contrib

Nazir Bilal Yavuz <byavuz81@gmail.com> — 2025-11-27T12:07:17Z

Hi,

Thank you for working on this!

On Thu, 27 Nov 2025 at 11:57, Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> Hi hackers,
>
> PFA patches to remove unused function parameters in contrib (more patches will
> come for non contrib).
>
> The patches are split by modules to ease the review.

I applied all patches and built/tested without any errors. So I guess
that the changes are correct.

I skimmed through 0001-0003 to see if I can find more parameters to
delete and found that we can remove the 'tinfo' parameter from the
gbt_var_node_truncate() function.

> For 0005 (collid not used in internal_citext_pattern_cmp()) I think that the
> unused column should be used (as done in 0005) due to an oversight in commit
> f2464997644c.

I do not have a context on this but there is a comment in the
citextcmp() function, which might be related to this context:

    /*
     * We must do our str_tolower calls with DEFAULT_COLLATION_OID, not the
     * input collation as you might expect.  This is so that the behavior of
     * citext's equality and hashing functions is not collation-dependent.  We
     * should change this once the core infrastructure is able to cope with
     * collation-dependent equality and hashing functions.
     */

-- 
Regards,
Nazir Bilal Yavuz
Microsoft