Horton
Menu

Re: Improve error reporting in 027_stream_regress test

Nazir Bilal Yavuz <byavuz81@gmail.com>

View thread
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-21T08:53:00Z
Lists: pgsql-hackers 
Hi,

On Sat, 19 Jul 2025 at 09:06, Michael Paquier <michael@paquier.xyz> wrote:
>
> This one looks acceptable to me, so applied to begin with something,
> splitting things into two pieces for clarity with some tweaks.  I have
> changed things to use system_log() at the end, with fat-commas to link
> the long options and their arguments.

Thanks!

I realized that we actually don't trim the file, we do the opposite;
read the file from both ends. Sorry for not realizing earlier. I will
update the remaining patches according to that but I think trim_file()
is helpful, too. What do you think about adding both

```
trim_file() -> trims $n lines from head or tail of the file and
returns the remaining lines.
read_file_ends() -> returns $n lines from head or tail of the file.
```

although trim_file() will not be used in these particular patches?

-- 
Regards,
Nazir Bilal Yavuz
Microsoft

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve error reporting of recovery test 027_stream_regress

  2. Add PostgreSQL::Test::Cluster::read_head_tail() helper to PostgreSQL/Utils.pm

  3. Handle timeout in PostgreSQL::Test::Cluster::is_alive()

  4. Check status of nodes after regression test run in 027_stream_regress

  5. Add PostgreSQL::Test::Cluster::is_alive()