Re: BUG #19095: Test if function exit() is used fail when linked static
Nazir Bilal Yavuz <byavuz81@gmail.com>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, BharatDB <bharatdbpg@gmail.com>, torsten.rupp@gmx.net, pgsql-bugs@lists.postgresql.org, VASUKI M <vasukim1992002@gmail.com>
Date: 2025-11-19T13:17:07Z
Lists: pgsql-bugs, pgsql-hackers
Attachments
- v1-0001-Add-exit-check-for-libpq.so-for-meson-build.patch (text/x-patch)
Hi, On Fri, 14 Nov 2025 at 15:11, Daniel Gustafsson <daniel@yesql.se> wrote: > > > On 12 Nov 2025, at 09:15, Michael Paquier <michael@paquier.xyz> wrote: > > > > On Wed, Nov 12, 2025 at 09:13:09AM +0100, Daniel Gustafsson wrote: > >> On 12 Nov 2025, at 07:38, Tom Lane <tgl@sss.pgh.pa.us> wrote: > >>> Personally I'm okay with whitelisting pthread_exit() as > >>> Torsten suggested. > >> > >> +1, we already have a few whitelisted entries and pthread_exit seems perfectly > >> reasonable to add to that list. > > > > WFM. > > The attached trivial diff adds this to the whitelist clause in the Makefile. I > experimented with adding this to Meson, and while it's trivial enough to do the > run_command with libpq_so.full_path, it's less clear to me exactly where in the > build it should be added. I've pinged my colleague Bilal who is much better at > Meson than me to collaborate on that as a separate fix. Sorry for the late reply. I replaced the Makefile portion with the Perl script, so that it can be used for both meson and autoconf build systems. The script takes two arguments - input_file -> path of library file. - stamp_file -> to create a stamp file for the meson build, so that meson does not run while the library file is not changed. Autoconf build does not use this option. -- Regards, Nazir Bilal Yavuz Microsoft