Thread

Re: Proposal: adding --enable-shadows-warning

Nazir Bilal Yavuz <byavuz81@gmail.com> — 2025-11-28T11:16:45Z

Hi,

On Fri, 28 Nov 2025 at 12:40, Chao Li <li.evan.chao@gmail.com> wrote:
>
> > On Nov 28, 2025, at 17:20, Daniel Gustafsson <daniel@yesql.se> wrote:
> >
> >> On 28 Nov 2025, at 10:02, Chao Li <li.evan.chao@gmail.com> wrote:
> >
> >> To make hacker’s life easier, it would make sense to always enable “-Wshadow”, however, that may have a risk of breaking some compilers. So thinking over, I just fell adding an opt-in “—enable-shadows-warnings” could be a solution.
> >
> > I'm not sure that adding buildsystem flags for compiler behaviour is the right
> > direction, isn't the environment variables like CFLAGS already covering this?
> >
>
> Like I explained in my first email, using PROFILE can append extra options to CFLAGS, I am always use this method to append ‘-O0’ to CFLAGS. However, this way is easy to missing the extra option to add. As CommitFest CI always enable -Wshadows, we should allow developers to always enable the option in local.

I think there might be misunderstanding here. Commitfest CI does not
enable '-Wshadow', it just sets '-Werror' before running the compiler
warnings checks. There is the '-Wshadow=compatible-local' flag which
is added at 0fe954c285 and it is always enabled when it is supported.

--
Regards,
Nazir Bilal Yavuz
Microsoft