Re: Building with meson on NixOS/nixpkgs

Nazir Bilal Yavuz <byavuz81@gmail.com>

From: Nazir Bilal Yavuz <byavuz81@gmail.com>

To: Wolfgang Walther <walther@technowledgy.de>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-03-18T12:25:58Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Support falling back to non-preferred readline implementation with meson
- 1091f8e0a48b 16.4 landed
- ed9d04463200 17.0 landed
- 67427f10093a 18.0 landed
Support absolute bindir/libdir in regression tests with meson
- 7f61882b638a 16.4 landed
- eb6765d57cfa 17.0 landed
- ff34ae368bdb 18.0 landed
Fallback to clang in PATH with meson
- 23be5206327c 16.4 landed
- a32ffeebfa63 17.0 landed
- 4d8de281b583 18.0 landed
Fallback to uuid for ossp-uuid with meson
- cc90d7823a6e 16.4 landed
- 469b97c52413 17.0 landed
- a00fae9d43e5 18.0 landed
meson: Add support for detecting ossp-uuid without pkg-config
- 2416fdb3ee30 18.0 cited

Hi,

Thank you for the patches!

On Sat, 16 Mar 2024 at 14:48, Wolfgang Walther <walther@technowledgy.de> wrote:
>
> To build on NixOS/nixpkgs I came up with a few small patches to
> meson.build. All of this works fine with Autoconf/Make already.

I do not have NixOS but I confirm that patches cleanly apply to master
and do pass CI. I have a small feedback:

0001 & 0002: Adding code comments to explain why they have fallback
could be nice.
0003: Looks good to me.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft