Thread

Re: headerscheck ccache support

Nazir Bilal Yavuz <byavuz81@gmail.com> — 2025-11-28T12:34:33Z

Hi

On Fri, 28 Nov 2025 at 14:39, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On 21.11.25 13:14, Álvaro Herrera wrote:
> >> Now ccache works.
> >
> > Sounds reasonable.  I notice that you're cleaning this file in a `rm`
> > line in the loop,
> >
> >> @@ -253,10 +249,11 @@ do
> >>      if ! $COMPILER $COMPILER_FLAGS -I $builddir -I $srcdir \
> >>              -I $builddir/src/include -I $srcdir/src/include \
> >>              -I $builddir/src/interfaces/libpq -I $srcdir/src/interfaces/libpq \
> >> -            $EXTRAINCLUDES $EXTRAFLAGS -c $tmp/test.$ext -o $tmp/test.o
> >> +            $EXTRAINCLUDES $EXTRAFLAGS -c $test_file_name.$ext -o $test_file_name.o
> >>      then
> >>              exit_status=1
> >>      fi
> >> +    rm -f "$test_file_name.$ext" "$test_file_name.o"
> >>   done
> >
> > but this means that if the script is interrupted halfway through, one
> > file or two files might remain in place.  Would it be possible to have
> > the current file name in a variable, so that the `trap` line can delete
> > them?
>
> Here is another patch set.

I could not apply patches cleanly. Am I missing something?

$ git am ~/Downloads/v2-0001-headerscheck-ccache-support.patch
Applying: headerscheck ccache support
error: patch failed: src/tools/pginclude/headerscheck:73
error: src/tools/pginclude/headerscheck: patch does not apply
Patch failed at 0001 headerscheck ccache support

-- 
Regards,
Nazir Bilal Yavuz
Microsoft