Horton

Re: split func.sgml to separated individual sgml files

Nazir Bilal Yavuz <byavuz81@gmail.com>

View thread View on postgr.es
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Florents Tselai <florents.tselai@gmail.com>, Euler Taveira <euler@eulerto.com>, Tom Lane <tgl@sss.pgh.pa.us>, jian he <jian.universality@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, Corey Huinker <corey.huinker@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-03T11:28:23Z
Lists: pgsql-hackers

Attachments

Hi,

On Thu, 2 Oct 2025 at 21:43, Andrew Dunstan <andrew@dunslane.net> wrote:
>
> On 2025-10-02 Th 8:52 AM, Nazir Bilal Yavuz wrote:
>
> I think there is one more problem that we need to think about. This
> test runs when the xmllint is enabled but it also requires docbook
> (docbook-xml on some OSes) to be installed, otherwise the test fails
> with 'I/O error : Attempt to load network entity
> http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd'. I think that
> we need to skip this test if the docbook can not be found in the
> system. Otherwise that would be a hassle for most of the people and
> buildfarm members. What do you think about this?
>
>
> Oops, missed seeing this earlier. Yes, I think we need to skip the test in the meson case. Probably nothing more needed for the Makefile.

Here is the patch which does that. It has a basic check for the
docbook and if the docbook can not be found, then meson skips the
test.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft

Commits

  1. Revert "Improve docs syntax checking"

  2. Improve docs syntax checking

  3. Teach doc/src/sgml/Makefile about the new func/*.sgml files.

  4. Split func.sgml into more manageable pieces

  5. Doc: add check to detect non-breaking spaces in the docs.