Re: ci: Skip minfree file in the cores_backtrace.sh
Nazir Bilal Yavuz <byavuz81@gmail.com>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Álvaro Herrera <alvherre@kurilemu.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Melanie Plageman <melanieplageman@gmail.com>, myon@debian.org
Date: 2026-04-07T11:05:23Z
Lists: pgsql-hackers
Attachments
- v2-0001-ci-Process-only-core-dump-files-in-cores_backtrac.patch (text/x-patch) patch v2-0001
Hi, This problem is still happening. On Fri, 17 Oct 2025 at 15:31, Daniel Gustafsson <daniel@yesql.se> wrote: > > > On 17 Oct 2025, at 14:25, Álvaro Herrera <alvherre@kurilemu.de> wrote: > > > > On 2025-Oct-17, Nazir Bilal Yavuz wrote: > > > >> first=1 > >> -for corefile in $(find "$directory" -type f) ; do > >> +# minfree is not a core file but may exists in the crash directory, skip it > >> +for corefile in $(find "$directory" -type f -not -name "minfree") ; do > >> if [ "$first" -eq 1 ]; then > >> first=0 > >> else > > > > This looks quite random. Why not do "find ... -name '*core*'" instead? > > I mean, if we have minfree there today, we could have maxbusy tomorrow > > or whatever. > > I think we should be able to count of the core directory on controlled CI > instances not being cluttered with random files - if it is we probably want a > test failure logged so we can look at it - but minfree is a special file for > core dump handling on some platforms so skipping that make sense I think. I see that we already search for *core* string in the cores_backtrace.sh script (we do it only for OpenBSD but I think it doesn't matter): ``` base=$(echo "$filename" | sed 's/\.core.*$//') ``` So, I wanted to continue with Álvaro's suggestion. v2 is attached. Example CI run: https://cirrus-ci.com/build/6447813132812288 -- Regards, Nazir Bilal Yavuz Microsoft
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
postgres_fdw, dblink: Validate use_scram_passthrough values
- 8a86aa313a71 19 (unreleased) cited