Re: Doc: fix track_io_timing description to mention pg_stat_io
Nazir Bilal Yavuz <byavuz81@gmail.com>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Hajime.Matsunaga@nttdata.com, pgsql-hackers@lists.postgresql.org, Masao.Fujii@nttdata.com
Date: 2024-06-27T12:00:33Z
Lists: pgsql-hackers
Hi, On Thu, 27 Jun 2024 at 14:30, Melanie Plageman <melanieplageman@gmail.com> wrote: > > On Thu, Jun 27, 2024 at 5:06 AM <Hajime.Matsunaga@nttdata.com> wrote: > > > > Hi, > > > > pg_stat_io has I/O statistics that are collected when track_io_timing is > > enabled, but it is not mentioned in the description of track_io_timing. > > I think it's better to add a description of pg_stat_io for easy reference. > > What do you think? > > Seems quite reasonable to me given that track_wal_io_timing mentions > pg_stat_wal. I noticed that the sentence about track_io_timing in the > statistics collection configuration section [1] only mentions reads > and writes -- perhaps it should also mention extends and fsyncs? Both suggestions look good to me. If what you said will be implemented, maybe track_wal_io_timing too should mention fsyncs? -- Regards, Nazir Bilal Yavuz Microsoft
Commits
-
doc: Update track_io_timing documentation to mention pg_stat_io.
- 0d483ad4cc4c 16.4 landed
- 0248762b2a8e 17.0 landed
- 05506510de6a 18.0 landed