Horton

Re: Show WAL write and fsync stats in pg_stat_io

Nazir Bilal Yavuz <byavuz81@gmail.com>

View thread
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Melanie Plageman <melanieplageman@gmail.com>, Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>, "bharath.rupireddyforpostgres@gmail.com" <bharath.rupireddyforpostgres@gmail.com>, Thomas Munro <thomas.munro@gmail.com>
Date: 2025-02-06T12:19:00Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix copy-paste error related to the autovacuum launcher in pgstat_io.c

  2. Move SQL tests of pg_stat_io for WAL data to recovery test 029_stats_restart

  3. Add data for WAL in pg_stat_io and backend statistics

  4. Improve comment on top of pgstat_count_io_op_time()

  5. Refactor pgstat_prepare_io_time() with an input argument instead of a GUC

Hi,

On Wed, 5 Feb 2025 at 08:30, Michael Paquier <michael@paquier.xyz> wrote:
>
> Please note that I have marked the CF entry at [1] as committed as the
> main goal of this thread has been achieved.  Do you want to pursue the
> topic about the potential refactorings in pgstat_tracks_io_op() and
> pgstat_tracks_io_object()?  There is a second one with the elimination
> of the write & sync columns for pg_stat_wal.  Both should have their
> own thread if worked on, and this thread has been already quite long.

Yes, I would like to work on these.

By saying potential refactorings in pgstat_tracks_io_op() and
pgstat_tracks_io_object(), do you mean converting if statements to
switch statements or something else?

-- 
Regards,
Nazir Bilal Yavuz
Microsoft