Horton

Re: Show WAL write and fsync stats in pg_stat_io

Nazir Bilal Yavuz <byavuz81@gmail.com>

View thread
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Melanie Plageman <melanieplageman@gmail.com>, Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>, "bharath.rupireddyforpostgres@gmail.com" <bharath.rupireddyforpostgres@gmail.com>, Thomas Munro <thomas.munro@gmail.com>
Date: 2025-02-06T12:39:05Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix copy-paste error related to the autovacuum launcher in pgstat_io.c

  2. Move SQL tests of pg_stat_io for WAL data to recovery test 029_stats_restart

  3. Add data for WAL in pg_stat_io and backend statistics

  4. Improve comment on top of pgstat_count_io_op_time()

  5. Refactor pgstat_prepare_io_time() with an input argument instead of a GUC

Hi,

On Thu, 6 Feb 2025 at 11:39, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Feb 06, 2025 at 07:32:01AM +0000, Bertrand Drouvot wrote:
> > That sounds ok, but I wonder if that's the best appropriate place. I could
> > think of the checkpointer test in 029_stats_restart.pl and the startup/standby
> > one in one related to standby (030_stats_cleanup_replica.pl?). Though that's
> > probably just a matter of taste.
>
> Hmm.  Your suggestion of 029_stats_restart.pl is a tempting choice,
> indeed, more in line with the fact that we are checking some stats
> data.  I did not think about that.
>
> Note that I'm OK about using 029 or even 030, as long as both queries
> stay together.

My vote goes to 029. It already has the '## check checkpoint and wal
stats are incremented due to restart' part and what we are adding is
similar to that.

On Thu, 6 Feb 2025 at 10:32, Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> s/and the primary WAL some writes/and the primary some WAL writes/

I am not a native speaker but 'primary writes some WAL with its
checkpointer' sounds better to me.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft