Horton

Re: pg_dumpall --roles-only interact with other options

Zsolt Parragi <zsolt.parragi@percona.com>

View thread View on postgr.es
From: Zsolt Parragi <zsolt.parragi@percona.com>
To: jian he <jian.universality@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, wangpeng <215722532@qq.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-02-06T09:36:43Z
Lists: pgsql-hackers

Attachments

Hello!

> I believe "schema" generally refers to object definitions, excluding
> things like roles and tablespaces.

Please see the attached tap test case. It works with the current
master branch, and fails with the patch. Basically my expectation is
that if we use dumpall --schema-only, we should be able to restore it
without errors, except for one error for the already existing
postgres/current user which it ignores.

I also found one more issue/behavior change: --no-schema --clean now
generates DROP statements (roles, tablespaces, databases), while
previously it didn't.

Commits

  1. pg_dumpall: Fix handling of conflicting options.

  2. pg_dump: Add dumpSchema and dumpData derivative flags.