Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks

On Mon, 29 Jun 2026, Michael Paquier <michael@paquier.xyz> wrote:
> +       errdetail("Only one recovery target can be set.  Parameters set: %s.",
> +                  buf.data),
> +       errhint("See pg_settings for the parameter values and where each is set."));
>
> pg_settings is just one way to look at these values. We have also
> SHOW and other interfaces. I would keep the errdetail() with your
> first sentence, make the errhint the second sentence of the
> errdetail().

Isn't mentioning pg_settings confusing instead of helpful during a
server restart? With a reload it can help, but when the server can't
start, hinting that the user should query pg_settings doesn't seem
that useful.