Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

Krasiyan Andreev <krasiyan@gmail.com>

From: Krasiyan Andreev <krasiyan@gmail.com>

To: Oliver Ford <ojford@gmail.com>

Cc: Tatsuo Ishii <ishii@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>, Vik Fearing <vik@postgresfriends.org>, Pg Hackers <pgsql-hackers@postgresql.org>, andrew@tao11.riddles.org.uk, David Fetter <david@fetter.org>

Date: 2025-03-29T07:51:55Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix coding style with "else".
- 20628b62e46e 19 (unreleased) landed
Fix multi WinGetFuncArgInFrame/Partition calls with IGNORE NULLS.
- 2d7b247cb414 19 (unreleased) landed
Fix Coverity issue reported in commit 2273fa32bce.
- dd766a441d69 19 (unreleased) landed
Use ereport rather than elog in WinCheckAndInitializeNullTreatment.
- 5f3808646f67 19 (unreleased) landed
Avoid uninitialized-variable warnings from older compilers.
- 71540dcdcb22 19 (unreleased) cited
Fix Coverity issues reported in commit 25a30bbd423.
- 2273fa32bce7 19 (unreleased) landed
Improve EXPLAIN's display of window functions.
- 8b1b342544b6 18.0 cited
Automatically generate node support functions
- 964d01ae90c3 16.0 cited

Hi,
Patch applies and compiles, all included tests passed and after the latest
fixes for non-nulls array, performance is near to lead/lag without support
of "ignore nulls".
I have been using the last version for more than one month in a production
environment with real data and didn't find any bugs, so It is ready for
committer status.

На чт, 13.03.2025 г. в 9:49 Oliver Ford <ojford@gmail.com> написа:

>
>
> On Sun, 9 Mar 2025, 20:07 Oliver Ford, <ojford@gmail.com> wrote:
>
>> On Sun, Mar 9, 2025 at 6:40 AM Tatsuo Ishii <ishii@postgresql.org> wrote:
>>
>>> > Attached version removes the non-nulls array. That seems to speed
>>> > everything up.  Running the above query with 1 million rows averages
>>> 450ms,
>>> > similar when using lead/lag.
>>>
>>> Great. However, CFbot complains about the patch:
>>>
>>> https://cirrus-ci.com/task/6364194477441024
>>>
>>>
>> Attached fixes the headerscheck locally.
>>
>
> v11 attached because the previous version was broken by commit 8b1b342
>
>>