Re: Configuration include directory
Selena Deckelmann <selena@chesnok.com>
From: Selena Deckelmann <selena@chesnok.com>
To: Noah Misch <noah@leadboat.com>, Greg Smith <greg@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-09-20T21:10:58Z
Lists: pgsql-hackers
Attachments
- config-directory-v6.patch (application/octet-stream) patch v6
Hello! I've spent a little time with this patch and have attached revision 6. Thanks, Noah, for a fantastically detailed review. The only thing I didn't do that Noah suggested was run pgindent on guc-file.l. A cursory search did not reveal source compatible with my operating system for 'indent'. If someone points me to it, I'd happily also comply with the request to reindent. And document how to do that on my platform(s). :) I did just remove the references to the Apache project etc. I agree that providing best practices is good, but I'm skeptical about including best practices piecemeal. Adding it to earlier tutorial sections would probably be a bit more visible IMO. I also added examples to postgresql.conf.sample, per a suggestion from Dave Page. -selena -- http://chesnok.com