Horton

Re: Some ExecSeqScan optimizations

Nikita Malakhov <hukutoc@gmail.com>

View thread
From: Nikita Malakhov <hukutoc@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, David Rowley <dgrowleyml@gmail.com>, Vladlen Popolitov <v.popolitov@postgrespro.ru>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Junwang Zhao <zhjwpku@gmail.com>
Date: 2025-07-11T11:03:42Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Refactor ExecScan() to allow inlining of its core logic

Hi Amit!

It's a pity I missed this thread when you developed the patch.
I've developed a feature recently and discovered that SeqScan
does not make use of scan keys, and there is a Tom Lane's
comment regarding this:
  * Note that unlike IndexScan, SeqScan never use keys in heap_beginscan
  * (and this is very bad) - so, here we do not check are keys ok or not.

Have you considered passing scan keys like it is done in IndexScan?

Thanks!

-- 
Regards,
Nikita Malakhov
Postgres Professional
The Russian Postgres Company
https://postgrespro.ru/