Re: PATCH: psql tab completion for SELECT
Edmund Horner <ejrh00@gmail.com>
From: Edmund Horner <ejrh00@gmail.com>
To: Vik Fearing <vik.fearing@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-01-26T00:20:07Z
Lists: pgsql-hackers
Attachments
- psql-select-tab-completion-v3.patch (application/octet-stream) patch v3
On 23 January 2018 at 21:47, Vik Fearing <vik.fearing@2ndquadrant.com> wrote: > Don't forget to include the list :-) > I'm quoting the entirety of the message---which I would normally trim---for > the archives. Thanks for spotting that. Sorry list! > If this were my patch, I'd have one query for 8.0, and then queries for all > currently supported versions if needed. If 9.2 only gets 8.0-level > features, that's fine by me. That limits us to a maximum of six queries. > Just because we keep support for dead versions doesn't mean we have to > retroactively develop for them. Au contraire. >> I'll make another patch version, with these few differences. I managed to do testing against servers on all the versions >= 8.0 and I discovered that prior to version 8.1 they don't support ALL/ANY on oidvectors; so I added another query form. But I don't like having so many different queries, so I am in favour of trimming it down. Can I leave that up to the committer to remove some cases or do we need another patch? > Great! Here's another.
Commits
-
In psql, restore old behavior of Query_for_list_of_functions.
- b6e132ddc860 11.0 landed
-
Add infrastructure to support server-version-dependent tab completion.
- 722408bcd1bd 11.0 landed