Horton

Re: A patch for get origin from commit_ts.

Madan Kumar <madankumar1993@gmail.com>

View thread View on postgr.es
From: Madan Kumar <madankumar1993@gmail.com>
To: "movead.li@highgo.ca" <movead.li@highgo.ca>
Cc: michael <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>, craig@2ndquadrant.com, petr@2ndquadrant.com, alvherre@2ndquadrant.com, andres@anarazel.de, soumyadeep2007@gmail.com
Date: 2020-06-30T01:17:27Z
Lists: pgsql-hackers 
Hello hackers,

We already have pg_xact_commit_timestamp() that returns the timestamp of
the commit. It may be better to have one single function returning both
timestamp and origin for a given transaction ID.

A second thing is that TransactionIdGetCommitTsData() was introdued in
core(73c986add). It has only one caller pg_xact_commit_timestamp() which
passes RepOriginId as NULL, making last argument to the
TransactionIdGetCommitTsData() a dead code in core.

Quick code search shows that it is getting used by pglogical (caller:
https://sources.debian.org/src/pglogical/2.3.2-1/pglogical_conflict.c/?hl=509#L509).
CCing Craig Ringer and Petr Jelinek for the inputs.

Warm Regards,
Madan Kumar K
"There is no Elevator to Success. You have to take the Stairs"

Commits

  1. Include replication origins in SQL functions for commit timestamp

  2. Create a script that can renumber manually-assigned OIDs.