Horton

Re: 001_password.pl fails with --without-readline

Soumya S Murali <soumyamurali.work@gmail.com>

View thread View on postgr.es
From: Soumya S Murali <soumyamurali.work@gmail.com>
To: Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Date: 2026-01-16T10:29:19Z
Lists: pgsql-hackers 
Hi,

On Fri, Jan 16, 2026 at 12:53 PM Oleg Tselebrovskiy
<o.tselebrovskiy@postgrespro.ru> wrote:
>
> Thanks for your answer!
>
> Personally, I can’t think of any more test scenarios that could be
> tested here (maybe some versions of readline library on some exotic
> OS could break, but that seems a little far fetched), so, if you see
> no further problems with the patches, you could change
> the commitfest entry status to "Ready for Committer", so we could get
> another opinion on patches and, if possible, get them committed.
>

Thank you for the clarification.
The patches seem correct based on the testing I have done so far and
for me I did not observe any further issues in both readline and
non-readline configurations. Since I am one of the reviewers and not
the only one. I consider my review as only one data point and I would
feel more comfortable if the patches also receive input from other
reviewers who may have more experience with this part of the code or
different testing environments.
I am happy to add my test results and observations to the CommitFest
entry to assist further review. Once others have had a chance to look
and review, it would likely be more appropriate to move the entry
forward.


Regards,
Soumya

Commits

  1. Make psql/t/030_pager.pl more robust.

  2. Improve guards against false regex matches in BackgroundPsql.pm.

  3. Fix unsafe pushdown of quals referencing grouping Vars

  4. tests: BackgroundPsql: Fix potential for lost errors on windows