Re: 001_password.pl fails with --without-readline
Soumya S Murali <soumyamurali.work@gmail.com>
From: Soumya S Murali <soumyamurali.work@gmail.com>
To: Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2026-01-20T06:55:53Z
Lists: pgsql-hackers
Hi all, Thank you for confirming the full commit hash. On Mon, Jan 19, 2026 at 3:16 PM Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru> wrote: > > > Could you please share the full commit hash or branch that these > > patches are based on? I will be happy to apply them again and re-run > > the full test coverage once it is available. > > The full commit hash is 34740b90bc123d645a3a71231b765b778bdcf049, > it’s the latest commit in repository on github, master branch, see [1] > > > I fetched all refs and tags locally and reset my tree to a clean > > origin/master, but I am unable to locate commit 34740b9 in my > > repository > > Maybe your origin is out-of-date or is just different? > What does ‘git remote get-url origin’ say in your local repository? My local workflow uses a fork repository for convenience, but the origin is the official PostgreSQL repository. I reset my tree to 34740b90bc123d645a3a71231b765b778bdcf049 commit as per suggested and have fetched all refs. But still I am unable to apply both v3 and v4 patches cleanly on that commit. Every time it fails with context mismatches in BackgroundPsql.pm (around line 100), even on a clean working tree. error: patch failed: src/test/perl/PostgreSQL/Test/BackgroundPsql.pm:100 error: src/test/perl/PostgreSQL/Test/BackgroundPsql.pm: patch does not apply error: patch failed: src/bin/psql/t/030_pager.pl:40 error: src/bin/psql/t/030_pager.pl: patch does not apply Anyway I am trying it and will let you know the status once I complete applying and testing the patches. Regards, Soumya
Commits
-
Make psql/t/030_pager.pl more robust.
- 6918434a4acb 19 (unreleased) landed
-
Improve guards against false regex matches in BackgroundPsql.pm.
- fc84b3977e20 14.21 landed
- f356e2888cdb 17.8 landed
- bb6aedeca8d4 15.16 landed
- a1d7ae2b2e38 19 (unreleased) landed
- 92b3cc5a28f1 18.2 landed
- 6548e4a10d18 16.12 landed
-
Fix unsafe pushdown of quals referencing grouping Vars
- 34740b90bc12 19 (unreleased) cited
-
tests: BackgroundPsql: Fix potential for lost errors on windows
- 8b886a4e3488 18.0 cited