Re: 001_password.pl fails with --without-readline
Soumya S Murali <soumyamurali.work@gmail.com>
From: Soumya S Murali <soumyamurali.work@gmail.com>
To: Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2026-01-19T09:34:47Z
Lists: pgsql-hackers
Hi all, On Mon, Jan 19, 2026 at 2:15 PM Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru> wrote: > > > I tried applying both the v3 and v4 patches on a clean branch tree > > reset to the current origin/master, but neither of them applied > > cleanly due to context mismatches in BackgroundPsql.pm and > > 030_pager.pl. I think the patches need rebasing on the current master > > before they can be tested further. I will be happy to re-test once > > rebased patches are available. > > Just applied both v3 and v4 onto 34740b9 with no conflicts. I don’t > see any commits that touch 030_pager.pl and BackgroundPsql.pm > last few days, so maybe you still have your code changes from > v1 or v2, or something from debugging v3 or v4? I see that you > specified clean code tree, but for me both v3 and v4 applied with > no trouble > Thank you for the guidance. I fetched all refs and tags locally and reset my tree to a clean origin/master, but I am unable to locate commit 34740b9 in my repository, so I assume it may be a local or abbreviated hash. On a fresh branch, both v3 and v4 patches failed to apply cleanly which suggests a base mismatch rather than an issue with the patches themselves. Could you please share the full commit hash or branch that these patches are based on? I will be happy to apply them again and re-run the full test coverage once it is available. Regards, Soumya
Commits
-
Make psql/t/030_pager.pl more robust.
- 6918434a4acb 19 (unreleased) landed
-
Improve guards against false regex matches in BackgroundPsql.pm.
- fc84b3977e20 14.21 landed
- f356e2888cdb 17.8 landed
- bb6aedeca8d4 15.16 landed
- a1d7ae2b2e38 19 (unreleased) landed
- 92b3cc5a28f1 18.2 landed
- 6548e4a10d18 16.12 landed
-
Fix unsafe pushdown of quals referencing grouping Vars
- 34740b90bc12 19 (unreleased) cited
-
tests: BackgroundPsql: Fix potential for lost errors on windows
- 8b886a4e3488 18.0 cited