Horton

Re: 001_password.pl fails with --without-readline

Soumya S Murali <soumyamurali.work@gmail.com>

View thread View on postgr.es
From: Soumya S Murali <soumyamurali.work@gmail.com>
To: Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Date: 2026-01-02T10:09:40Z
Lists: pgsql-hackers

Attachments

Hi,

I reapplied the patch and tested the patch with (enable-tap-tests +
readline and enable-tap-tests + without-readline). I think the issue
was caused by differences in how psql emits prompts and echoed output
without readline which could lead to banner interleaving, timeouts or
premature TAP termination. In my patch I included the fixes that make
banner detection in BackgroundPsql.pm to be tolerant while keeping
strict line-based cleanup to preserve correct TAP behavior. The fix is
behavior-based and does not rely on configuration variables or test
skipping.
Kindly review my patch attached herewith and please let me know the feedback.

Regards
Soumya

Commits

  1. Make psql/t/030_pager.pl more robust.

  2. Improve guards against false regex matches in BackgroundPsql.pm.

  3. Fix unsafe pushdown of quals referencing grouping Vars

  4. tests: BackgroundPsql: Fix potential for lost errors on windows