Horton
Menu

Re: [HACKERS][PATCH] adding simple sock check for windows

DaeMyung Kang <charsyam@gmail.com>

View thread
From: CharSyam <charsyam@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-03-31T12:38:55Z
Lists: pgsql-hackers

Attachments

Thanks Amit.
I had a mistake. Thank you again to point it out :)


2018-03-31 19:33 GMT+09:00 Amit Kapila <amit.kapila16@gmail.com>:
> On Sat, Mar 31, 2018 at 12:05 PM, CharSyam <charsyam@gmail.com> wrote:
>> Amit, I agree with you.
>>
>> I changed my patch :) to remove old check.
>>
>
> - if (slot->sock < 0)
> + if (slot->sock == PGINVALID_SOCKET || slot->sock < 0)
>
> I still see the same check. I think by mistake you have attached old patch.
>
> --
> With Regards,
> Amit Kapila.
> EnterpriseDB: http://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix assorted issues in parallel vacuumdb.