Re: [HACKERS][PATCH] adding simple sock check for windows

Amit, I agree with you.

I changed my patch :) to remove old check.

2018-03-31 15:17 GMT+09:00 Amit Kapila <amit.kapila16@gmail.com>:
> On Sat, Mar 31, 2018 at 11:42 AM, CharSyam <charsyam@gmail.com> wrote:
>> Hi, Amit, It's good question. I also thought about it.
>>
>> But, I want to leave original code intention.
>>
>> Actually I think there is no case ( slot->sock is not PGINVALID_SOCKET
>> and slot->sock < 0)
>>
>> but if original code want to check (sock < -1)
>>
>
> If you see the code of PQsocket, then that won't be possible.
>
>
>> I think it is better to leave that condition.
>>
>> but I think slot->sock == PGINVALID_SOCKET is enough
>>
>
> It is up to you, but I don't see any reason to retain the old check.
>
> --
> With Regards,
> Amit Kapila.
> EnterpriseDB: http://www.enterprisedb.com