Horton

Re: snapbuild woes

Craig Ringer <craig.ringer@2ndquadrant.com>

View thread View on postgr.es
From: Craig Ringer <craig.ringer@2ndquadrant.com>
To: Kevin Grittner <kgrittn@gmail.com>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2016-12-12T02:42:33Z
Lists: pgsql-hackers 
On 12 December 2016 at 00:36, Kevin Grittner <kgrittn@gmail.com> wrote:
> On Sun, Dec 11, 2016 at 1:17 AM, Craig Ringer
> <craig.ringer@2ndquadrant.com> wrote:
>> On 11 Dec. 2016 06:50, "Petr Jelinek" <petr.jelinek@2ndquadrant.com> wrote:
>>> On 10/12/16 23:10, Petr Jelinek wrote:
>>>
>>>> The attached 0002-Skip-unnecessary-snapshot-builds.patch changes this
>>>> behavior so that we don't make snapshots for transactions that we seen
>>>> wholly and know that they didn't make catalog changes even if we didn't
>>>> reach consistency yet.
>>>
>>> Eh, attached wrong patch. This one is correct.
>>
>> Attached no patch second time?
>
> I see an attachment, and it shows in the archives.
>
> https://www.postgresql.org/message-id/aee1d499-e3ca-e091-56da-1ee6a47741c8%402ndquadrant.com

Sorry for the noise, apparently my phone's mail client was being dense.

-- 
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix thinko introduced in 2bef06d516460 et al.

  2. Avoid superfluous work for commits during logical slot creation.

  3. Fix race condition leading to hanging logical slot creation.

  4. Don't use on-disk snapshots for exported logical decoding snapshot.

  5. Preserve required !catalog tuples while computing initial decoding snapshot.