Re: PATCH: Batch/pipelining support for libpq
Craig Ringer <craig@2ndquadrant.com>
From: Craig Ringer <craig@2ndquadrant.com>
To: Daniel Verite <daniel@manitou-mail.org>
Cc: Michael Paquier <michael.paquier@gmail.com>,
Dmitry Igrishin <dmitigr@gmail.com>, Andres Freund <andres@anarazel.de>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Manuel Kniep <m.kniep@web.de>, "fujita.etsuro@lab.ntt.co.jp" <fujita.etsuro@lab.ntt.co.jp>
Date: 2016-09-06T11:01:50Z
Lists: pgsql-hackers
On 6 September 2016 at 16:10, Daniel Verite <daniel@manitou-mail.org> wrote: > Craig Ringer wrote: > >> Updated patch attached. > > Please find attached a couple fixes for typos I've came across in > the doc part. Thanks, will apply and post a rebased patch soon, or if someone picks this up in the mean time they can apply your diff on top of the patch. > Also it appears that PQqueriesInBatch() doesn't work as documented. > It says: > "Returns the number of queries still in the queue for this batch" > but in fact it's implemented as a boolean: Whoops. Will fix. I think the function is useful and necessary. There's no reason not to expose that, but also it's good for when your query dispatch isn't as tightly coupled to your query handling as in the example, so your app might need to keep processing until it sees the end of queued results. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Commits
-
Add libpq pipeline mode support to pgbench
- 9aa491abbf07 14.0 landed
-
Implement pipeline mode in libpq
- acb7e4eb6b1c 14.0 landed