Horton

Thread

Commits

  1. Install pg_isolation_regress and isolationtester

  1. [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Craig Ringer <craig@2ndquadrant.com> — 2018-05-28T07:06:05Z

    Hi

Per topic, the Pg makefiles install pg_regress (for use by extensions) and
htey install the isolationtester, but they don't install
pg_isolation_regress.

We should install it too.

-- 
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

  2. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Craig Ringer <craig@2ndquadrant.com> — 2018-06-01T03:46:05Z

    On 28 May 2018 at 15:06, Craig Ringer <craig@2ndquadrant.com> wrote:

> Hi
>
> Per topic, the Pg makefiles install pg_regress (for use by extensions) and
> htey install the isolationtester, but they don't install
> pg_isolation_regress.
>
> We should install it too.
>

Now with a patch that isn't brain-dead.

I'm wondering if I should add ISOLATION support to PGXS too, like we have
REGRESS .

-- 
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

  3. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2020-09-29T14:09:44Z

    On 2018-Jun-01, Craig Ringer wrote:

> On 28 May 2018 at 15:06, Craig Ringer <craig@2ndquadrant.com> wrote:
> 
> > Per topic, the Pg makefiles install pg_regress (for use by extensions) and
> > htey install the isolationtester, but they don't install
> > pg_isolation_regress.
> >
> > We should install it too.

I happened to come across this thread by accident, and I tend to agree
that we need to install both isolationtester and pg_isolation_regress to
the pgxs dirs, just like we do pg_regress.  I can't find that
isolationtester is installed anywhere though; maybe that changed after
you posted this.  Anyway, this version of the patch installs both.

I did search for evidence in the Makefile's git log that would remove a
recipe for installing isolationtester; couldn't find anything.

> I'm wondering if I should add ISOLATION support to PGXS too, like we have
> REGRESS .

This was covered by Michael's d3c09b9b1307 a few months after you
posted.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  4. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Craig Ringer <craig@2ndquadrant.com> — 2020-09-30T02:12:04Z

    On Tue, 29 Sep 2020 at 22:09, Alvaro Herrera <alvherre@2ndquadrant.com>
wrote:

> On 2018-Jun-01, Craig Ringer wrote:
>
> > On 28 May 2018 at 15:06, Craig Ringer <craig@2ndquadrant.com> wrote:
> >
> > > Per topic, the Pg makefiles install pg_regress (for use by extensions)
> and
> > > htey install the isolationtester, but they don't install
> > > pg_isolation_regress.
> > >
> > > We should install it too.
>
> I happened to come across this thread by accident, and I tend to agree
> that we need to install both isolationtester and pg_isolation_regress to
> the pgxs dirs, just like we do pg_regress.  I can't find that
> isolationtester is installed anywhere though; maybe that changed after
> you posted this.  Anyway, this version of the patch installs both.
>

Thanks.

I think rules were added to allow the isolation tester to be installed with
an explicit make -C src/test/isolation install, but not added to the
default "install" target.

I agree it should just be installed.

-- 
 Craig Ringer                   http://www.2ndQuadrant.com/
 2ndQuadrant - PostgreSQL Solutions for the Enterprise

  5. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2020-10-15T16:20:39Z

    On 2020-Sep-30, Craig Ringer wrote:

> On Tue, 29 Sep 2020 at 22:09, Alvaro Herrera <alvherre@2ndquadrant.com>
> wrote:

> > I happened to come across this thread by accident, and I tend to agree
> > that we need to install both isolationtester and pg_isolation_regress to
> > the pgxs dirs, just like we do pg_regress.  I can't find that
> > isolationtester is installed anywhere though; maybe that changed after
> > you posted this.  Anyway, this version of the patch installs both.

> I think rules were added to allow the isolation tester to be installed with
> an explicit make -C src/test/isolation install, but not added to the
> default "install" target.
> 
> I agree it should just be installed.

Pushed, thanks.

  6. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2020-10-15T16:47:36Z

    On 2020-Oct-15, Alvaro Herrera wrote:

> Pushed, thanks.

I forgot to mention that I considered backpatching this and decided not
to, but only because it might confuse packagers if they see unrecognized
files in the installation.  I realize now that c3a0818460a8 was
back-patched.  Any opinions on backpatching?

  7. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Tom Lane <tgl@sss.pgh.pa.us> — 2020-10-15T17:06:54Z

    Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I forgot to mention that I considered backpatching this and decided not
> to, but only because it might confuse packagers if they see unrecognized
> files in the installation.  I realize now that c3a0818460a8 was
> back-patched.  Any opinions on backpatching?  

We've added new installed files in minor releases before, true.
But I agree it's something to do only when pretty important, and I'm
not sure this clears the bar.  TAP tests (the facility added by that
other patch) seem way more commonly useful than isolation tests.

Quickly counting the uses in our existing in-core extensions, I see

TAP_TESTS: 3 contrib, 5 src/test/modules
ISOLATION: 1 contrib, 3 src/test/modules

Other than src/test/modules/brin, the ISOLATION users don't look
much like real extensions (rather than test scaffolding), either.
If you discount test scaffolding modules then the use-counts are
more like 4 to 1.

So I'm -0.1 or so on backpatching.

			regards, tom lane

  8. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Michael Paquier <michael@paquier.xyz> — 2020-10-16T01:00:32Z

    On Thu, Oct 15, 2020 at 01:06:54PM -0400, Tom Lane wrote:
> Other than src/test/modules/brin, the ISOLATION users don't look
> much like real extensions (rather than test scaffolding), either.
> If you discount test scaffolding modules then the use-counts are
> more like 4 to 1.

Out of core, the only thing I can see with isolation tests is rum, but
it uses a workaround to have an access to the necessary binaries.
--
Michael

  9. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Craig Ringer <craig.ringer@enterprisedb.com> — 2020-10-16T02:19:28Z

    On Fri, 16 Oct 2020, 09:00 Michael Paquier, <michael@paquier.xyz> wrote:

> On Thu, Oct 15, 2020 at 01:06:54PM -0400, Tom Lane wrote:
> > Other than src/test/modules/brin, the ISOLATION users don't look
> > much like real extensions (rather than test scaffolding), either.
> > If you discount test scaffolding modules then the use-counts are
> > more like 4 to 1.
>
> Out of core, the only thing I can see with isolation tests is rum, but
> it uses a workaround to have an access to the necessary binaries.
>

I would've liked to backpatch but don't really care very much. If it's
going to take time away from others things, don't do it.

I landed up having to make my own lightly customised postgres packages to
use as test workflow inputs anyway. So I included the full set of isolation
test utilities, packaged the test inputs etc.

I'd prefer not to have to do it, but it's done. So long as it's fixed going
forward it didn't matter that much.

Now server_version_num on the other hand ... :P

  10. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Aleksander Alekseev <aleksander@timescale.com> — 2021-04-28T09:44:45Z

    Hi hackers,

> Any opinions on backpatching?

> Other than src/test/modules/brin, the ISOLATION users don't look
> much like real extensions (rather than test scaffolding), either.

> Out of core, the only thing I can see with isolation tests is rum, but
> it uses a workaround to have an access to the necessary binaries.

I just wanted to let you know that TimescaleDB uses
pg_isolation_regress and occasionally there are reports from some
suffering/puzzled users/developers, e.g. [1]. Not 100% sure if it
makes investing the time into backpatching worth it. However if
someone could do it, it would be nice.

[1]: https://github.com/timescale/timescaledb/issues/1655

-- 
Best regards,
Aleksander Alekseev

  11. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Michael Paquier <michael@paquier.xyz> — 2021-04-29T02:33:46Z

    On Wed, Apr 28, 2021 at 12:44:45PM +0300, Aleksander Alekseev wrote:
> I just wanted to let you know that TimescaleDB uses
> pg_isolation_regress and occasionally there are reports from some
> suffering/puzzled users/developers, e.g. [1]. Not 100% sure if it
> makes investing the time into backpatching worth it. However if
> someone could do it, it would be nice.

FWIW, I am not really sure that this is important enough to justify a
back-patch, even it is true that there have been cases in the past
where extra binaries got added in minor releases.
--
Michael

  12. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Tom Lane <tgl@sss.pgh.pa.us> — 2021-04-29T02:41:38Z

    Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Apr 28, 2021 at 12:44:45PM +0300, Aleksander Alekseev wrote:
>> I just wanted to let you know that TimescaleDB uses
>> pg_isolation_regress and occasionally there are reports from some
>> suffering/puzzled users/developers, e.g. [1]. Not 100% sure if it
>> makes investing the time into backpatching worth it. However if
>> someone could do it, it would be nice.

> FWIW, I am not really sure that this is important enough to justify a
> back-patch, even it is true that there have been cases in the past
> where extra binaries got added in minor releases.

Yeah, I think adding a binary in a minor release is a Big Deal to
packagers.  I doubt that the case here justifies that.

			regards, tom lane

  13. Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

    Magnus Hagander <magnus@hagander.net> — 2021-04-29T10:40:34Z

    On Thu, Apr 29, 2021 at 4:41 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Michael Paquier <michael@paquier.xyz> writes:
> > On Wed, Apr 28, 2021 at 12:44:45PM +0300, Aleksander Alekseev wrote:
> >> I just wanted to let you know that TimescaleDB uses
> >> pg_isolation_regress and occasionally there are reports from some
> >> suffering/puzzled users/developers, e.g. [1]. Not 100% sure if it
> >> makes investing the time into backpatching worth it. However if
> >> someone could do it, it would be nice.
>
> > FWIW, I am not really sure that this is important enough to justify a
> > back-patch, even it is true that there have been cases in the past
> > where extra binaries got added in minor releases.
>
> Yeah, I think adding a binary in a minor release is a Big Deal to
> packagers.  I doubt that the case here justifies that.

+1.

Given the number of complaints from people lacking it since the binary
was first created, I can't see how that's a priority that justifies
that.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/