Re: Add support for restrictive RLS policies
Craig Ringer <craig@2ndquadrant.com>
From: Craig Ringer <craig@2ndquadrant.com>
To: Jeevan Chalke <jeevan.chalke@enterprisedb.com>
Cc: Stephen Frost <sfrost@snowman.net>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, Thom Brown <thom@linux.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2016-09-29T03:12:52Z
Lists: pgsql-hackers
On 27 September 2016 at 15:15, Jeevan Chalke <jeevan.chalke@enterprisedb.com> wrote: > Hello Stephen, > > On Tue, Sep 27, 2016 at 12:57 AM, Stephen Frost <sfrost@snowman.net> wrote: >> >> Jeevan, >> >> * Jeevan Chalke (jeevan.chalke@enterprisedb.com) wrote: >> > I have started reviewing this patch and here are couple of points I have >> > observed so far: >> > >> > 1. Patch applies cleanly >> > 2. make / make install / initdb all good. >> > 3. make check (regression) FAILED. (Attached diff file for reference). >> >> I've re-based my patch on top of current head and still don't see the >> failures which you are getting during the regression tests. Is it >> possible you were doing the tests without a full rebuild of the source >> tree..? >> >> Can you provide details of your build/test environment and the full >> regression before and after output? > > > I still get same failures with latest sources and with new patch. Here are > few details of my setup. Let me know if I missed any. > > $ uname -a > Linux centos7 3.10.0-327.28.3.el7.x86_64 #1 SMP Thu Aug 18 19:05:49 UTC 2016 > x86_64 x86_64 x86_64 GNU/Linux > > HEAD at > commit 51c3e9fade76c12e4aa37bffdf800bbf74fb3fb1 > > configure switches: > ./configure --with-openssl --with-tcl --with-perl --with-python > --with-ossp-uuid --with-ldap --with-pam --with-zlib --with-pgport=5432 > --enable-depend --enable-debug --enable-cassert --prefix=`pwd`/install > CFLAGS="-g -O0" I suggest: git reset --hard git clean -fdx ccache -C then re-apply patch and re-check. I've had a couple of issues recently caused by ccache doing something funky :( but haven't been able to track it down yet. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Commits
-
Add support for restrictive RLS policies
- 093129c9d9fc 10.0 landed
-
Include <sys/select.h> where needed
- 51c3e9fade76 10.0 cited
-
Apply table and domain CHECK constraints in name order.
- e5f455f59fed 9.5.0 cited