Horton

Re: Should we remove -Wdeclaration-after-statement?

Isaac Morland <isaac.morland@gmail.com>

View thread
From: Isaac Morland <isaac.morland@gmail.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, "ranier.vf@gmail.com" <ranier.vf@gmail.com>, chap@anastigmatix.net
Date: 2024-01-29T15:35:03Z
Lists: pgsql-hackers 
On Mon, 29 Jan 2024 at 10:31, Mark Dilger <mark.dilger@enterprisedb.com>
wrote:

>
>
> > On Jan 29, 2024, at 7:03 AM, Jelte Fennema-Nio <postgres@jeltef.nl>
> wrote:
> >
> > So my suggestion is for people to respond with -1, -0.5, +-0, +0.5, or
> > +1 to indicate support against/for the change.
>
> -1 for me.
>
> -Infinity for refactoring the entire codebase and backpatching.
>

I don't think anybody is proposing re-working the existing codebase. I
understand this to be only about allowing new code to use the newer style.
Personally, I like, as much as possible, to use initializations to const
variables and avoid assignment operators, so I much prefer to declare at
first (and usually only) assignment.

But not voting because the amount of code I’ve actually contributed is
minuscule.