Thread

Re: Improve GetConfigOptionValues function

Nitin Jadhav <nitinjadhavpostgres@gmail.com> — 2023-01-23T09:59:16Z

> The v2 patch looks good to me except the comment around
> ConfigOptionIsShowable() which is too verbose. How about just "Return
> whether the GUC variable is visible or not."?

Sounds good. Updated in the v3 patch attached.


> I think you can add it to CF, if not done, to not lose track of it.

Added https://commitfest.postgresql.org/42/4140/

Thanks & Regards,
Nitin Jadhav

On Mon, Jan 23, 2023 at 11:30 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Thu, Jan 19, 2023 at 3:27 PM Nitin Jadhav
> <nitinjadhavpostgres@gmail.com> wrote:
> >
> > > Possibly a better answer is to refactor into separate functions,
> > > along the lines of
> > >
> > > static bool
> > > ConfigOptionIsShowable(struct config_generic *conf)
> > >
> > > static void
> > > GetConfigOptionValues(struct config_generic *conf, const char **values)
> >
> > Nice suggestion. Attached a patch for the same. Please share the
> > comments if any.
>
> The v2 patch looks good to me except the comment around
> ConfigOptionIsShowable() which is too verbose. How about just "Return
> whether the GUC variable is visible or not."?
>
> I think you can add it to CF, if not done, to not lose track of it.
>
> --
> Bharath Rupireddy
> PostgreSQL Contributors Team
> RDS Open Source Databases
> Amazon Web Services: https://aws.amazon.com