Back patch of Remove durable_rename_excl()

Nitin Jadhav <nitinjadhavpostgres@gmail.com>

From: Nitin Jadhav <nitinjadhavpostgres@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Nathan Bossart <nathandbossart@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2025-01-27T12:45:09Z

Lists: pgsql-hackers

Hi,

I noticed that the corruption issue related to two hardlinks pointing
to the same WAL file has been fixed in the master branch up to version
16 in commit [1]. As a result, the function durable_rename_excl()
became unused and was removed in commit [2]. Since this corruption
issue is occurring in older versions, commit [1] has been backported
for versions 13 to 15 in commit [3]. However, I don't see the
backporting for commit [2]. Is there a specific reason for this? If
not, I would suggest backporting commit [2] for versions 13 to 15 as
well.

[1]: https://github.com/postgres/postgres/commit/dac1ff30906b9cef7859380905d038892b32968b
[2]: https://github.com/postgres/postgres/commit/eb64ceac7ec3422f2370b8824dce62ee8fe52dca
[3]: https://github.com/postgres/postgres/commit/c1c9df3159cfa91416bebe56ae50bc32d8a4e10b

Best Regards,
Nitin Jadhav
Azure Database for PostgreSQL
Microsoft