Re: [PATCH] Bug fix in initdb output
Nitin Jadhav <nitinjadhavpostgres@gmail.com>
From: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-02T08:37:12Z
Lists: pgsql-hackers
> > FWIW, I don't think that it is a good idea to come back to this > decision for *nix platforms, so I would let it as-is, and use relative > paths if initdb is called using a relative path. The command to be displayed either in absolute path or relative path depends on the way the user is calling initdb. I agree with the above comment to keep this behaviour as-is, that is if the initdb is called using relative path, then it displays relative path otherwise absolute path. > However, if you can write something that > makes the path printed compatible for a WIN32 terminal while keeping > the behavior consistent with other platforms, people would have no > objections to that. I feel the patch attached above handles this scenario. Thanks and Regards, Nitin Jadhav On Tue, Mar 2, 2021 at 6:53 AM Michael Paquier <michael@paquier.xyz> wrote: > On Tue, Mar 02, 2021 at 01:28:57AM +0100, Juan José Santamaría Flecha > wrote: > > For me it is a +1 for the change to absolute. Let's see if more people > want > > to weigh in on the matter. > > FWIW, I don't think that it is a good idea to come back to this > decision for *nix platforms, so I would let it as-is, and use relative > paths if initdb is called using a relative path. > > The number of people using a relative path for Windows initialization > sounds rather limited to me. However, if you can write something that > makes the path printed compatible for a WIN32 terminal while keeping > the behavior consistent with other platforms, people would have no > objections to that. > -- > Michael >
Commits
-
Use native path separators to pg_ctl in initdb
- f927767919e8 12.7 landed
- b52fd1e7c76c 13.3 landed
- ae1c1d84ea24 11.12 landed
- 926139dd04bb 10.17 landed
- 75dbfe4ca70d 14.0 landed
-
Have initdb display relative paths to start postmaster if used to invoke
- ee814b4511ec 8.0.0 cited