Re: Address the bug in 041_checkpoint_at_promote.pl
Nitin Jadhav <nitinjadhavpostgres@gmail.com>
From: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
Michael Paquier <michael@paquier.xyz>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2025-02-13T14:04:15Z
Lists: pgsql-hackers
> > Anyway, how did you find that? Did you see a pattern when running the > > test on a very slow machine or just from a read? That was a good > > catch. > +1. I was wondering the same. I was writing a TAP test to reproduce a crash recovery issue and used parts of 041_checkpoint_at_promote.pl. Unfortunately, my test wasn't waiting for the desired message to appear in the log. I then realized there was a mistake in log_contains(), which I had copied from the existing test. After testing 041_checkpoint_at_promote.pl multiple times to see if it worked as expected, I noticed differences in some iterations. Best Regards, Nitin Jadhav Azure Database for PostgreSQL Microsoft On Thu, Feb 13, 2025 at 11:18 AM Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> wrote: > > On Thu, Feb 13, 2025 at 5:08 AM Michael Paquier <michael@paquier.xyz> wrote: > > > > Anyway, how did you find that? Did you see a pattern when running the > > test on a very slow machine or just from a read? That was a good > > catch. > +1. I was wondering the same. > > > -- > Best Wishes, > Ashutosh Bapat