Horton

Re: [PATCH] psql : Improve code for help option

Nitin Jadhav <nitinjadhavpostgres@gmail.com>

View thread View on postgr.es
From: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: miyake_kouta <miyake_kouta@oss.nttdata.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-03T08:05:04Z
Lists: pgsql-hackers 
Hi,

I have reviewed the patch and it looks good to me.

Thanks and Regards,
Nitin Jadhav

On Wed, Mar 3, 2021 at 1:09 PM Fujii Masao <masao.fujii@oss.nttdata.com>
wrote:

>
>
> On 2021/03/03 12:27, miyake_kouta wrote:
> > 2021-03-03 00:09, Fujii Masao wrote:
> >> We can simplify the code more and remove "env = user"
> >> by just using "user" instead of "env" in the above?
> >
> > Thank you for your comment.
> > I updated my patch and replaced "env" with "user".
> > Please check.
>
> Thanks for updating the patch!
> LGTM. Barrying any objection, I will commit this patch.
>
> Regards,
>
> --
> Fujii Masao
> Advanced Computing Technology Center
> Research and Development Headquarters
> NTT DATA CORPORATION
>
>
>

Commits

  1. Remove redundant getenv() for PGUSER, in psql help.