Re: REINDEX CONCURRENTLY 2.0

Jeff Janes <jeff.janes@gmail.com>

From: Jeff Janes <jeff.janes@gmail.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Jim Nasby <Jim.Nasby@bluetreble.com>, Andres Freund <andres@2ndquadrant.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2014-11-10T18:24:58Z
Lists: pgsql-hackers
On Wed, Nov 5, 2014 at 8:49 PM, Michael Paquier <michael.paquier@gmail.com>
wrote:

> On Thu, Oct 30, 2014 at 5:19 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
> > Updated patch is attached.
> Please find attached an updated patch with the following things changed:
> - Addition of tab completion in psql for all new commands
> - Addition of a call to WaitForLockers in index_concurrent_swap to
> ensure that there are no running transactions on the parent table
> running before exclusive locks are taken on the index and its
> concurrent entry. Previous patch versions created deadlocks because of
> that, issue spotted by the isolation tests integrated in the patch.
> - Isolation tests for reindex concurrently are re-enabled by default.
> Regards,
>

It looks like this needs another rebase, I get failures
on index.c, toasting.c, indexcmds.c, and index.h

Thanks,

Jeff

Commits

  1. Prevent reindex of invalid indexes on TOAST tables

  2. Rework handling of invalid indexes with REINDEX CONCURRENTLY

  3. Split builtins.h to a new header ruleutils.h