Horton

Thread

Commits

  1. extended stats: Clarify behavior of omitting stat type clause

  1. CREATE STATISTICS statistic_type documentation

    Jeff Janes <jeff.janes@gmail.com> — 2017-05-25T16:12:08Z

    The docs for CREATE STATISTICS does not say what happens if the
statistic_type clause is omitted.  It should probably say that the default
action is to create both ndistinct and dependencies.

Cheers,

Jeff

  2. Re: CREATE STATISTICS statistic_type documentation

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-05-25T16:28:34Z

    Jeff Janes <jeff.janes@gmail.com> writes:
> The docs for CREATE STATISTICS does not say what happens if the
> statistic_type clause is omitted.  It should probably say that the default
> action is to create both ndistinct and dependencies.

Hmm, I coulda sworn that it did say that somewhere.

Where would you expect to find that?

			regards, tom lane

  3. Re: CREATE STATISTICS statistic_type documentation

    Jeff Janes <jeff.janes@gmail.com> — 2017-05-25T16:43:23Z

    On Thu, May 25, 2017 at 9:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Jeff Janes <jeff.janes@gmail.com> writes:
> > The docs for CREATE STATISTICS does not say what happens if the
> > statistic_type clause is omitted.  It should probably say that the
> default
> > action is to create both ndistinct and dependencies.
>
> Hmm, I coulda sworn that it did say that somewhere.
>
> Where would you expect to find that?
>

Probably at the end of the paragraph:

"A statistic type to be computed in this statistics object. Currently
supported types are ndistinct, which enables n-distinct statistics, and
dependencies, which enables functional dependency statistics. For more
information, see Section 14.2.2 and Section 68.2."

Something like "If omitted, both ndistinct and dependencies will be
included."

If we invent more types in the future, would we expect those to be
defaulted to as well?

Cheers,

Jeff

  4. Re: CREATE STATISTICS statistic_type documentation

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-05-25T17:05:48Z

    Jeff Janes <jeff.janes@gmail.com> writes:
> On Thu, May 25, 2017 at 9:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Where would you expect to find that?

> Probably at the end of the paragraph:
> "A statistic type to be computed in this statistics object. Currently
> supported types are ndistinct, which enables n-distinct statistics, and
> dependencies, which enables functional dependency statistics. For more
> information, see Section 14.2.2 and Section 68.2."

Fair enough.

> Something like "If omitted, both ndistinct and dependencies will be
> included."

> If we invent more types in the future, would we expect those to be
> defaulted to as well?

I might be wrong, but my impression is that the plan is to default
to gathering all possible stats types.  So I'd probably write the
addendum that way rather than naming those two types specifically.

			regards, tom lane

  5. Re: CREATE STATISTICS statistic_type documentation

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2017-05-25T17:13:58Z

    Tom Lane wrote:
> Jeff Janes <jeff.janes@gmail.com> writes:
> > On Thu, May 25, 2017 at 9:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> > If we invent more types in the future, would we expect those to be
> > defaulted to as well?
> 
> I might be wrong, but my impression is that the plan is to default
> to gathering all possible stats types.  So I'd probably write the
> addendum that way rather than naming those two types specifically.

Yes -- that plan has been hardcoded in ruleutils.c.

I'll patch.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services