Horton

Re: pgbench stats per script & other stuff

Jeff Janes <jeff.janes@gmail.com>

View thread View on postgr.es
From: Jeff Janes <jeff.janes@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Michael Paquier <michael.paquier@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2016-03-19T18:08:18Z
Lists: pgsql-hackers 
On Sat, Mar 19, 2016 at 8:41 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> I pushed your 25, with some additional minor tweaks.  I hope I didn't
> break anything; please test.

I'm now getting compiler warnings:

gcc version 4.4.7 20120313 (Red Hat 4.4.7-16) (GCC)


pgbench.c: In function 'process_builtin':
pgbench.c:2765: warning: 'ps.stats.lag.sum2' is used uninitialized in
this function
pgbench.c:2765: warning: 'ps.stats.lag.sum' is used uninitialized in
this function
pgbench.c:2765: warning: 'ps.stats.lag.max' is used uninitialized in
this function
pgbench.c:2765: warning: 'ps.stats.lag.min' is used uninitialized in
this function
pgbench.c:2765: warning: 'ps.stats.lag.count' is used uninitialized in
this function
pgbench.c:2765: warning: 'ps.stats.latency.sum2' is used uninitialized
in this function
pgbench.c:2765: warning: 'ps.stats.latency.sum' is used uninitialized
in this function
pgbench.c:2765: warning: 'ps.stats.latency.max' is used uninitialized
in this function
pgbench.c:2765: warning: 'ps.stats.latency.min' is used uninitialized
in this function
pgbench.c:2765: warning: 'ps.stats.latency.count' is used
uninitialized in this function
pgbench.c:2765: warning: 'ps.stats.skipped' is used uninitialized in
this function
pgbench.c:2765: warning: 'ps.stats.cnt' is used uninitialized in this function
pgbench.c:2765: warning: 'ps.stats.start_time' is used uninitialized
in this function
pgbench.c:2765: warning: 'ps.weight' is used uninitialized in this function

Commits

  1. pgbench: Allow changing weights for scripts