Horton

Re: narwhal and PGDLLIMPORT

Jeff Janes <jeff.janes@gmail.com>

View thread
From: Jeff Janes <jeff.janes@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2014-02-04T18:00:03Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. MinGW: Link with shell32.dll instead of shfolder.dll.

  2. Centralize getopt-related declarations in a new header file pg_getopt.h.

  3. Get rid of use of dlltool in Mingw builds.

  4. Export a few more symbols required for test_shm_mq module.

  5. Export set_latch_on_sigusr1 symbol for Windows.

  6. Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the

On Tue, Feb 4, 2014 at 8:06 AM, Andrew Dunstan <andrew@dunslane.net> wrote:

>
> On 02/04/2014 10:43 AM, Tom Lane wrote:
>
>>
>> Ugh.  This problem was bad enough when I thought that it would only lead
>> to link-time errors detectable in the buildfarm.  If it can lead to errors
>> only observable at runtime --- and maybe not obvious even then --- then
>> I think we *have to* do something about it.  By that I mean that we must
>> get rid of the need to manually plaster PGDLLIMPORT on global variables.
>>
>> Anybody with a Windows build environment want to test the "#define extern"
>> trick?
>>
>>
>>
>
>
>
> We have details on how to build with Mingw/Msys on Windows on an Amazon VM
> <http://wiki.postgresql.org/wiki/Building_With_MinGW> which is either
> free or very cheap. Do I need to give instructions on how to do this for
> MSVC builds too? It's really not terribly hard.
>


If you gave step by step instructions like the ones for MinGW, I would at
least give it a try.  Last time a looked into it, I gave up after I
couldn't figure out which of the umpteen similarly-named products was the
one I needed to buy/download-for-free/register-and-download and then
install, and I tried a few of them at random without much success.

Cheers,

Jeff