Horton

Thread

Commits

  1. Update postgresql.conf.sample comment for bgwriter_lru_maxpages

  1. bgwriter_lru_maxpages range in postgresql.conf

    Jeff Janes <jeff.janes@gmail.com> — 2017-11-16T18:26:59Z

    (My earlier post has been stuck in infinite moderation due to the use of a
common 6 letter abbreviation for configuration, so I will try again without
it)


With v10, commit 14ca9abfbe4643408a, the upper limit on
bgwriter_lru_maxpages was changed from 1000 to INT_MAX / 2, but
the postgresql.conf.sample was not updated.

#bgwriter_lru_maxpages = 100        # 0-1000 max buffers written/round

I don't see any precedence for including INT_MAX-type limits in the sample
configuration file, so maybe something like this:?

#bgwriter_lru_maxpages = 100        # max buffers written/round, 0 to turn
off

Cheers,

Jeff

  2. Re: bgwriter_lru_maxpages range in postgresql.conf

    Robert Haas <robertmhaas@gmail.com> — 2017-11-16T19:10:30Z

    On Thu, Nov 16, 2017 at 1:26 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
> (My earlier post has been stuck in infinite moderation due to the use of a
> common 6 letter abbreviation for configuration, so I will try again without
> it)
>
> With v10, commit 14ca9abfbe4643408a, the upper limit on
> bgwriter_lru_maxpages was changed from 1000 to INT_MAX / 2, but the
> postgresql.conf.sample was not updated.
>
> #bgwriter_lru_maxpages = 100        # 0-1000 max buffers written/round
>
> I don't see any precedence for including INT_MAX-type limits in the sample
> configuration file, so maybe something like this:?
>
> #bgwriter_lru_maxpages = 100        # max buffers written/round, 0 to turn
> off

wfm.  Patch?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  3. Re: bgwriter_lru_maxpages range in postgresql.conf

    Jeff Janes <jeff.janes@gmail.com> — 2017-11-16T21:40:50Z

    On Thu, Nov 16, 2017 at 11:10 AM, Robert Haas <robertmhaas@gmail.com> wrote:

> On Thu, Nov 16, 2017 at 1:26 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
> > (My earlier post has been stuck in infinite moderation due to the use of
> a
> > common 6 letter abbreviation for configuration, so I will try again
> without
> > it)
> >
> > With v10, commit 14ca9abfbe4643408a, the upper limit on
> > bgwriter_lru_maxpages was changed from 1000 to INT_MAX / 2, but the
> > postgresql.conf.sample was not updated.
> >
> > #bgwriter_lru_maxpages = 100        # 0-1000 max buffers written/round
> >
> > I don't see any precedence for including INT_MAX-type limits in the
> sample
> > configuration file, so maybe something like this:?
> >
> > #bgwriter_lru_maxpages = 100        # max buffers written/round, 0 to
> turn
> > off
>
> wfm.  Patch?
>

I changed it to "0 disables" to be more consistent with other locations.

Cheers,

Jeff

  4. Re: bgwriter_lru_maxpages range in postgresql.conf

    Robert Haas <robertmhaas@gmail.com> — 2017-11-17T19:55:32Z

    On Thu, Nov 16, 2017 at 4:40 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
> I changed it to "0 disables" to be more consistent with other locations.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company