Re: add verbosity to pg_basebackup for sync

Jeff Janes <jeff.janes@gmail.com>

From: Jeff Janes <jeff.janes@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-29T14:45:10Z
Lists: pgsql-hackers
On Fri, Jul 27, 2018 at 7:10 PM, Michael Paquier <michael@paquier.xyz>
wrote:

> On Fri, Jul 27, 2018 at 11:58:42AM -0400, Jeff Janes wrote:
> > But it was really waiting for the syncs of the new -D dir to finish.  The
> > attached patch adds a -v notice that it is starting to do the sync, with
> > the wording taken from initdb's equivalent message.
>
> This is a good idea.  Would we want that back-patched?  I am sure that
> nobody is going to complain for an extra informational log.
>

Thanks for committing it.  It is probably safer not to backpatch, as
someone might have scripts that look at the output of -v so it shouldn't
change between minor releases.  I don't think looking at those would be a
good idea, but they may have their reasons.

Cheers,

Jeff

Commits

  1. Add verbosity to pg_basebackup for sync