Re: COPY FREEZE and PD_ALL_VISIBLE

Jeff Janes <jeff.janes@gmail.com>

From: Jeff Janes <jeff.janes@gmail.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Simon Riggs <simon@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2015-12-24T03:24:45Z
Lists: pgsql-hackers
On Wed, Dec 23, 2015 at 6:14 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Wed, Nov 4, 2015 at 12:08 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> On Tue, Nov 3, 2015 at 8:07 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>>
>>> On 3 November 2015 at 15:23, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>>>
>>>> On Fri, Oct 23, 2015 at 6:29 AM, Simon Riggs <simon@2ndquadrant.com>
>>>> wrote:
>>>>>
>>>>> Easy enough to do it at the end of the COPY FREEZE in one step.
>>>>
>>>>
>>>> Here, we might want to consider that setting bit in visibility map
>>>> will generate WAL log whereas Copy Freeze otherwise skip WAL
>>>> when wal_level is less than archive.  This can lead to extra disk
>>>> writes which can slow down Copy Freeze, but OTOH that might
>>>> be acceptable.
>>>
>>>
>>> I'm building the map as I go, in the latest version of this patch I'm
>>> working on.
>>>
>>
>> As, you are working on this patch, I have marked it as "Waiting on Author".
>
> There has not been an update for this patch in a while, switched to
> "returned with feedback" because of lack of author's input.

And I've added Simon as an author, as I don't plan on picking it up
again myself as long as he is working on his alternative.

Thanks,

Jeff


Commits

  1. Set PD_ALL_VISIBLE and visibility map bits in COPY FREEZE