Re: [PATCH] Increase the maximum value track_activity_query_size

Jeff Janes <jeff.janes@gmail.com>

From: Jeff Janes <jeff.janes@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nikolay Samokhvalov <samokhvalov@gmail.com>, Michael Paquier <michael@paquier.xyz>, Bruce Momjian <bruce@momjian.us>, Alexey Kondratov <a.kondratov@postgrespro.ru>, v.makarov@postgrespro.ru, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-12-29T17:46:50Z
Lists: pgsql-hackers
On Tue, Dec 24, 2019 at 12:11 AM Robert Haas <robertmhaas@gmail.com> wrote:

> On Sat, Dec 21, 2019 at 1:25 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > > What is the overhead here except the memory consumption?
> >
> > The time to copy those strings out of shared storage, any time
> > you query pg_stat_activity.
>
> It seems like you're masterminding this, and I don't know why. It
> seems unlikely that anyone will raise the value unless they have very
> long queries, and if those people would rather pay the overhead of
> copying more data than have their queries truncated, who are we to
> argue?
>

+1

Cheers,

Jeff

Commits

  1. Increase the maximum value of track_activity_query_size.